update externs for 2017-era implementations #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samthor is this still worth looking at? |
|
If the Web Animations API hasn't changed, which I don't think it has, then yes. The current version doesn't express the whole API available in Chrome, and folks using Closure might struggle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Timelineinterfaces into the main externsAnimationa constructor, not an interface (i.e., we didn't allownew Animation)id, including makingAnimationEffectTimingPropertiesa@recordso it can be extended byKeyframeAnimationOptionsand used onelement.animate(which returns anAnimationwithid).I've also made it clear that the -next externs are just for the polyfill, and that they don't match the spec.
Plus some misc cleanups (e.g. remove
opt_from optional arguments—no longer required by Closure).